antivirak / japonsko-vn

RenPy visual novel about gaijin trip to japan
0 stars 0 forks source link

Feature/parking bill minigame #51

Open antivirak opened 4 months ago

antivirak commented 4 months ago

Summary by Sourcery

Add a new parking bill minigame with dynamic logic and difficulty settings, enhance visual effects with nighttime transformations, and refactor code for improved readability and efficiency.

New Features:

Enhancements:

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request introduces a new parking bill minigame and adds nighttime visual transformations to enhance the game's aesthetics. The changes primarily focus on implementing the minigame logic, updating existing game mechanics, and improving code efficiency.

Sequence Diagram

sequenceDiagram
    participant User
    participant ParkingDisplayable
    participant DynamicLogic
    participant RenpyRender

    User->>ParkingDisplayable: Move mouse
    ParkingDisplayable->>DynamicLogic: update_input()
    ParkingDisplayable->>DynamicLogic: update_logic()
    DynamicLogic-->>ParkingDisplayable: Return game state
    ParkingDisplayable->>RenpyRender: Update visual elements
    RenpyRender-->>User: Display updated game state

File-Level Changes

Change Details Files
Implemented a new parking bill minigame
  • Created a new ParkingDisplayable class to handle the game's visual elements
  • Implemented various DynamicLogic classes (Simple, SimpleCont, Newton, Mash) for different difficulty levels
  • Added a new screen and label for the parking machine game
  • Integrated mouse control and visual feedback for the minigame
game/parking_machine_ren.py
game/minigame_parking_machine.rpy
Added nighttime visual transformations
  • Created nighttime1 and nighttime2 transforms for darker and tinted visuals
  • Applied nighttime transforms to the Fuji parking lot scene
game/story/akt4.rpy
Optimized existing game logic and code structure
  • Refactored get_active_notes_per_drum method in taiko_ren.py for better efficiency
  • Simplified equality check in Person class
  • Improved spiciness calculation in ichiran_radio_buttons_ren.py
  • Updated game menu screen handling in minigame_rhytmic.rpy
game/taiko_ren.py
game/person_ren.py
game/ichiran_radio_buttons_ren.py
game/minigame_rhytmic.rpy

Tips and commands - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
antivirak commented 4 months ago

@sourcery-ai review

antivirak commented 2 months ago

@sourcery-ai review

antivirak commented 1 month ago

Rebased to develop

antivirak commented 1 month ago

Works now with window resizing on my machine, but not on other laptop. Probably I need to scale the config.screen_width as well as I did with renpy.game.properties.physical_size