antiwinter / wowa

WoW addon manager, world of warcraft, addon, lua, command line, cli
https://www.npmjs.com/package/wowa
MIT License
58 stars 8 forks source link

nolib version of some curse addons being installed #30

Closed Llamatron2112 closed 4 years ago

Llamatron2112 commented 4 years ago

It looks like wowa installs the -nolib version of some addons hosted on Curse, at least it's doing it for me with Ark Inventory and Chocolate Bar, and they stop working as the libs they depend on are not here.

Their page : https://www.curseforge.com/wow/addons/ark-inventory https://www.curseforge.com/wow/addons/chocolatebar

Might be others, but thoses two broke after a wowa update.

EDIT: Forgot to mention it is for classic version, didn't test with retail as I don't have it installed

Llamatron2112 commented 4 years ago

I just found the @version you can add behind a package name to install a specific version, for example for ArkInventory: wowa add curse:ark-inventory@3.09.12-Classic will install the version with libs. You can see which versions are available by looking at the "Files" tab on the website.

Would be nice if the readme mentionned this, and also the --anyway flag.

EDIT: wowa update reinstalled the -nolib version

antiwinter commented 4 years ago

Thank you for the feedback.

I've just submitted a commit to filter out the -nolib versions. I would do some tests later and make a release.

The versions wowa gets from API is not exactly matched with the list you can see on the website, so I didn't mention it in the readme...

antiwinter commented 4 years ago

Version is released, sorry for late responding, I was busy leveling my mage...

Llamatron2112 commented 4 years ago

No worries for the delay, not that it was making wowa not functional :)

I need to wait for some ark-inventory update to see if it is fixed for me too, but right now I notice there's a warning about a deprecated syntax at each wowa command:

[@octokit/rest] const Octokit = require("@octokit/rest") is deprecated. Use const { Octokit } = require("@octokit/rest") instead

Llamatron2112 commented 4 years ago

It doesn't install the nolib version anymore, thanks for your work !

antiwinter commented 4 years ago

OK, I am going to close this issue and I will pay attention to the deprecated warning.