Add ParseTreeProperty class

antlr / antlr-php-runtime

PHP Runtime for ANTLR4

BSD 3-Clause "New" or "Revised" License

81 stars 19 forks source link

Add ParseTreeProperty class #8

Open HermanPeeren opened 3 years ago

HermanPeeren commented 3 years ago

fixes #7

marcospassos commented 3 years ago

@HermanPeeren I'll set up a workflow for running automated tests and code style checks over the next days, and then I'm going to come back to this, ok?

HermanPeeren commented 3 years ago

OK, thanks!

Was also working on unit-tests for the php-runtime, as they are missing in the repo now. Or do you already have some tests, that are not in this repo yet?
You'll probably comply to PSR-12, or do you have a specific codestyle-document for the php-runtime-files? Just adjusted mine.

marcospassos commented 3 years ago

@HermanPeeren we follow the style specified here.

Currently, the library is covered by functional tests. Unit tests and performance tweaks are great contributions at the moment.

HermanPeeren commented 3 years ago

@HermanPeeren we follow the style specified here.

Haha, I cou;ld have seen that... have to look better. Will use that in PHPstorm.

Thanks for reviewing, @marcospassos ! Very welcome!

marcospassos commented 2 years ago

Hi @HermanPeeren! Are you still interested in working on this PR?