search

antlr / antlr4

ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.
http://antlr.org
BSD 3-Clause "New" or "Revised" License
17.03k stars 3.27k forks source link

The pom.xml file for antlr4-runtime does not include the url as part of its metadata #2371

Open thehcma opened 5 years ago

thehcma commented 5 years ago

Automated tooling that extracts information from a package metadata yields a bad URL, since the it is not explicitly defined.

For instance in the main artifact (e.g., antlr4-4.7.1.pom) we have:

    <name>ANTLR 4 Tool</name>                                                                                            
    <url>http://www.antlr.org</url>                                                                                      
    <description>The ANTLR 4 grammar compiler.</description>

In the runtime artifact (e.g., antlr4-runtime-4.7.1.pom) we have:

    <name>ANTLR 4 Runtime</name>
    <description>The ANTLR 4 Runtime</description>

but no url element.

ericvergnaud commented 5 years ago

Maybe submit a PR?

Le 6 oct. 2018 à 00:49, Henrique notifications@github.com a écrit :

Automated tooling that extracts information from a package metadata yields a bad URL, since the it is not explicitly defined.

For instance in the main artifact (e.g., antlr4-4.7.1.pom) we have:

ANTLR 4 Tool http://www.antlr.org The ANTLR 4 grammar compiler. In the runtime artifact (e.g., antlr4-runtime-4.7.1.pom) we have: ANTLR 4 Runtime The ANTLR 4 Runtime but no url element. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub , or mute the thread .
sharwell commented 5 years ago

Isn't it inherited from the parent pom?

sharwell commented 5 years ago

Yep, it's defined here:

https://github.com/antlr/antlr4/blob/432022fc1ca098f2ab419d6e26a09124a518c345/pom.xml#L21

Sounds like a bug in the tooling that extracts the metadata since the inheritance behavior for this property is explicitly defined for Maven.