search

antlr / antlr4

ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.
http://antlr.org
BSD 3-Clause "New" or "Revised" License
17.22k stars 3.29k forks source link

C#, Antlr4.Runtime.Standard 4.10.0, invalid signature #3653

Open podprad opened 2 years ago

podprad commented 2 years ago

Hello,

I've upgraded Antlr4.Runtime.Standard from 4.8.0 to 4.10.0 and now my web project (that run on IIS) complains about invalid strong name signature:

Could not load file or assembly 'Antlr4.Runtime.Standard' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)

I verified the signature manually by sn.exe:

where sn.exe C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\sn.exe

sn -v Antlr4.Runtime.Standard.dll

Old version 4.8.0:

netstandard1.3 Assembly 'Antlr4.Runtime.Standard.dll' is valid

net35 Assembly 'Antlr4.Runtime.Standard.dll' is valid

New version 4.10.0:

netstandard2.0 Failed to verify assembly -- Strong name validation failed.

So it looks there is really something wrong with the signature.

I used the DLL included in the nuget package:

https://www.nuget.org/packages/Antlr4.Runtime.Standard/

Best regards, Michael

KvanTTT commented 2 years ago

It's probably realted to #3360

cam-m commented 2 years ago

Seems to also affect v4.10.1.

Any chance of a patch version bump with the correctly signed package?

ItCommitsTheCode commented 2 years ago

This issue starts precisely at 4.9.3 and continues through to current releases. The last, correctly-signed version is 4.9.2, based on my testing.

Barteling commented 2 years ago

This issue starts precisely at 4.9.3 and continues through to current releases. The last, correctly-signed version is 4.9.2, based on my testing.

I believe so too,

Any change to solve this in a patch?

ericvergnaud commented 2 years ago

There is no bug fix in C# runtime > 4.9.2 so you can stick to that version until the code signing issue is fixed in the next release

Le 22 août 2022 à 09:22, Gerhard Barteling @.***> a écrit :

This issue starts precisely at 4.9.3 and continues through to current releases. The last, correctly-signed version is 4.9.2, based on my testing.

I believe so too,

Any change to solve this in a patch?

— Reply to this email directly, view it on GitHub https://github.com/antlr/antlr4/issues/3653#issuecomment-1221954460, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNQJHYJTZA6EBZQIVCN5DV2MTD3ANCNFSM5TLZRNEQ. You are receiving this because you are subscribed to this thread.

Barteling commented 2 years ago

That is clear, thanks for all the awesome work you do

Just wondering if you found a cause, because I reported it already for 4.9.3? #3360