antlr / antlr5

BSD 3-Clause "New" or "Revised" License
57 stars 5 forks source link

Updating documentations for ANTLR 5 #23

Closed ftomassetti closed 9 months ago

ftomassetti commented 9 months ago

This PR does a combination of minor things to update references to ANTLR4 into references to ANTLR5.

Moved to the #26 instead:

ftomassetti commented 9 months ago

Can we have separate PRs for code changes and doc changes ?

Sure, I extracted #26 to focus on code and infrastructure, and I have updated this PR to focus exclusively on documentation

ftomassetti commented 9 months ago

In this case, after I performed the changes requested, should I press the button Re-request review or is it enough to add a comment in the PR?

ericvergnaud commented 9 months ago

In this case, after I performed the changes requested, should I press the button Re-request review or is it enough to add a comment in the PR?

I guess the former expresses clearly that from your POV it is ready ?

ericvergnaud commented 9 months ago

Plus technically I think it triggers a review workflow, which maybe helps close the previous review. Let's find out ?

ftomassetti commented 9 months ago

Thanks, I pressed the button

ericvergnaud commented 9 months ago

It does help close the previous review 😄