search

antlr / antlr5

BSD 3-Clause "New" or "Revised" License
53 stars 4 forks source link

Fix failed tests caused by merging two MRs that affect each other a bit #35

Closed KvanTTT closed 7 months ago

KvanTTT commented 7 months ago

https://github.com/antlr/antlr5/pull/30 https://github.com/antlr/antlr5/pull/31

ericvergnaud commented 7 months ago

Already fixed by #33

KvanTTT commented 7 months ago

But it should be merged at first and it's another change. You can rebase your branch on dev later.

ericvergnaud commented 7 months ago

But it should be merged at first and it's another change. You can rebase your branch on dev later.

We don't have a product yet, so not sure we need to follow such a strict process during the initial phase of the project ? I find it counterproductive. Once we have a product released, then we will definitely need to be much more accurate.

ericvergnaud commented 7 months ago

Already fixed, closing.

KvanTTT commented 7 months ago

We don't have a product yet, so not sure we need to follow such a strict process during the initial phase of the project ? I find it counterproductive.

I don't find it's conuterproductive. The thing we don't have an agreement is much more couterproductive since it forces to develop different forks and not to coordinate resources.