search

antlr / antlr5

BSD 3-Clause "New" or "Revised" License
57 stars 5 forks source link

refactor v4 -> v5 #4

Closed ericvergnaud closed 10 months ago

ericvergnaud commented 10 months ago
ericvergnaud commented 10 months ago

I've reached a state where it compiles - no attempts to test Merging so it can be used by other contributors Partially fixes #3

KvanTTT commented 10 months ago

Sorry, but could you please wait for approvement from at least one member next time? It's community-driven project but not one-person-driven, isn't it?

Also, please use git squashing next time to get rid of useless commits (or squash/edit them manually). Now I see a lot of non-informative commits in antlr5 history instead of one meaningful commit.

I don't understand why we are rushing.

ericvergnaud commented 10 months ago

Hey, ok to squash in the future. I'm just making sure we rapidly reach a situation where people can start contributing on a viable basis, which is where we are now i.e. the project compiles.

KvanTTT commented 10 months ago

Hey, ok to squash in the future.

Thanks.

I'm just making sure we rapidly reach a situation where people can start contributing on a viable basis, which is where we are now i.e. the project compiles.

I don't think changing version number affects users' contributions and experience. Project was compilable before this change.