added TypeScript target and some modifications

antlr / grammars-v4

Grammars written for ANTLR v4; expectation that the grammars are free of actions.

MIT License

10.22k stars 3.71k forks source link

added TypeScript target and some modifications #4242

Closed RobEin closed 1 month ago

RobEin commented 2 months ago

added TypeScript target
update to ANTLR 4.13.2
update to Python 3.12.6

kaby76 commented 2 months ago

typescript-collections is not in the project.json for testing. I'll add it as a default with https://github.com/antlr/grammars-v4/issues/4243.

kaby76 commented 2 months ago

update to ANTLR 4.13.2. Could you describe which targets require 4.13.2 here? There is no version 4.13.2 for the CSharp target.

RobEin commented 2 months ago

The following four parsers require ANTLR 4.13.2:

JavaScript target for Python 2.7.18 (because of depricated Recognizer.getErrorListenerDispatch(): #4562)
TypeScript target for Python 2.7.18 (because of depricated Recognizer.getErrorListenerDispatch(): #4562)
JavaScript target for Python 3.12.6 (because of depricated features: #4562)
TypeScript target for Python 3.12.6 (because of depricated and new features: #4562)

kaby76 commented 1 month ago

Now I understand. The JavaScript port requires Antlr 4.13.2 because this PR uses the API Lexer.setMode(). Unfortunately, the build locks all grammars that have a JavaScript port at 4.13.2. So, the old API mode() outputs a deprecation warning, which is a breaking change--all output from the tester is captured and compared. I don't think there are many JS ports that use the old API, but I will need add per-grammar, per-version testing when specified in the desc.xml.

kaby76 commented 1 month ago

Please synch with "master" to see whether the build is fixed.

teverett commented 1 month ago

@kaby76 ready to merge?

kaby76 commented 1 month ago

@teverett Yes, please merge.

teverett commented 1 month ago

@RobEin thanks!