Open stephendrew opened 7 years ago
I believe this will fix #553 and #643
Actually, I notice some attempt has been made at adding these keywords to the regular_id
already, but the list seems incorrect (e.g. DELETE
is a keyword and can be an identifier).
You are right: regular_id
contains some keywords. It would be great if you add missing and remove wrong keywords from this rule :)
In my divergent grammar, which I am trying to reconcile with this, I had a separate plsql_keyword
(and plsql_reserved_word
) rule - which approach do you prefer - using such a rule? Or simply adding to regular_id
...?
I like your approach.
Suggest making a rule for keyword tokens, and allow them to be used as identifiers.