antlr / stringtemplate4

StringTemplate 4
http://www.stringtemplate.org
Other
955 stars 231 forks source link

What work is needed to upgrade st4 to use antlr4? #175

Closed xied75 closed 6 years ago

xied75 commented 7 years ago

Currently st4 needs antlr3 runtime. I wonder how much work is required to upgrade this dependency to antlr runtime v4?

KvanTTT commented 7 years ago

antlr4 also use antlr3 :)

xied75 commented 7 years ago

@KvanTTT Thanks for the head up. :) I think it definitely worth it to break this chain.

A quick question if you don't mind answering, I see there is a public partial class CodeGenerator : Antlr.Runtime.Tree.TreeParser with a CodeGenerator.g3, what is this? (Sorry that I started with Antlr4, has zero knowledge about the history). Is this concept still around in Antlr4?

xied75 commented 6 years ago

Dear all, just to say I've got a working st4 on antlr4.standard, if you think it's any value to the community, I could turn that into a public repository. Let me know.

parrt commented 6 years ago

Wow! That sounds like a lot of work. How big were the changes? Oh and I guess that's for C# not Java.

xied75 commented 6 years ago

But it should be easy to get the work back to Java. Most of the "difficulties" is getting the grammar work. Another issue is that the work was done last June, so it might "diverged" from the upstream since then. Not sure how much though. What's your suggestion? I could simply turn the switch and let the community to carry on?

parrt commented 6 years ago

Well, it's no longer my focus so I'm unlikely to find the time to update. thanks though!