search

antlr / stringtemplate4

StringTemplate 4
http://www.stringtemplate.org
Other
955 stars 231 forks source link

Loading templates in containers #207

Closed drealeed closed 6 years ago

drealeed commented 6 years ago

To facilitate getting this in I applied the patch attached to issue #191 and put in a pull request for it.

I also built the jar and tested it with our external products; the patch fixed the issues without introducing others.

Fixes #191

parrt commented 6 years ago

@drealeed is this similar to https://github.com/antlr/stringtemplate4/pull/199 ?

parrt commented 6 years ago

@drealeed could you sign https://github.com/antlr/stringtemplate4/blob/master/contributors.txt ?

drealeed commented 6 years ago

Done: https://github.com/antlr/stringtemplate4/pull/208

parrt commented 6 years ago

Passed all tests.

drealeed commented 6 years ago

Thanks very much for pulling this. Will there be a snapshot/rc build deployed out to mvnrepository or another repo?

parrt commented 6 years ago

I'll try to do that this weekend.

dabayliss commented 6 years ago

Thank you @parrt - I have a team of two dozen people drilling st4/antlr - if we had failed at the deployment step I'd have had egg running down both sides of my face ....

parrt commented 6 years ago

is there an antlr4 PR too you need?

parrt commented 6 years ago

Please try 4.0.9-SNAPSHOT via maven or pull down and try from here. seems to work for me on my projects.

drealeed commented 6 years ago

Thanks! We also include antlr and antlr runtime. When testing my fix locally I had to manually exclude stringtemplate from those two projects' maven dependencies, for my local stringtemplate 4.0.9-SNAPSHOT to be picked up rather than the stringtemplate included with antlr. Can those also be recompiled?

parrt commented 6 years ago

(Changed name to 4.1 from 4.0.9). Added some more stuff. Will test with antlr again.

parrt commented 6 years ago

@drealeed released 4.1!!!