search

antmicro / zynq-mkbootimage

An open source replacement of the Xilinx bootgen application.
BSD 2-Clause "Simplified" License
93 stars 47 forks source link

Makefile: fix linker flags #1

Closed willplatts closed 7 years ago

willplatts commented 7 years ago

… required to compile with gcc (probably due to --as-needed?) See https://ubuntuforums.org/showthread.php?t=1877055

tgorochowik commented 7 years ago

Hello Will,

thank you for your contribution, you are right that this might be causing issues on some systems. We will gladly accept your patch, but it has to be a little bit cleaner for us to do so. Are you interested in doing this?

willplatts commented 7 years ago

Hi

Yes I will have a look at your suggestions. Thanks for the tips, I didn't know what variables should be used!

Will

On Wed, Feb 8, 2017 at 8:16 AM, Tomasz Gorochowik notifications@github.com wrote:

Hello Will,

thank you for your contribution, you are right that this might be causing issues on some systems. We will gladly accept your patch, but it has to be a little bit cleaner for us to do so. Are you interested in doing this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/antmicro/zynq-mkbootimage/pull/1#issuecomment-278260563, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlcbJc8UheoPbJBuF4MTUDIbw2PSvXfks5raXnhgaJpZM4L6E2K .

tgorochowik commented 7 years ago

Thanks, perfect!