Fix group annotation collision bug

antocuni / capnpy

Other

45 stars 26 forks source link

Fix group annotation collision bug #45

Closed davidjlloyd closed 5 years ago

davidjlloyd commented 5 years ago

We were storing field overrides by name and code order, which is not unique and led to group annotations being applied incorrectly. Solution is to use the ID of the field instead.

davidjlloyd commented 5 years ago

The build seems to be failing for some unrelated reason on PyPy (looks like Travis is failing to install PyPy locally for testing) but passes for everything else. Probably an issue just with the tests themselves.