search

antoine-coulon / skott

All-in-one devtool to automatically analyze, search and visualize project modules and dependencies from JavaScript, TypeScript (JSX/TSX) and Node.js (ES6, CommonJS)
MIT License
669 stars 25 forks source link

Make incremental comparison consistent for all types of project structure #22

Closed antoine-coulon closed 1 year ago

antoine-coulon commented 1 year ago

Since v0.12.1, incremental mode was enabled by default. It turns out that this works well for JavaScript/TypeScript standard configurations but lacks off consistency when being used with more advanced configurations (specifically TypeScript deep path aliases #20) and TypeScript/JavaScript edge cases of path resolutions.

From now on with #21 until a fix (will be resolved with this issue), incremental will be disabled by default (can still be used with the flag incremental: true).

This feature will eventually be enabled by default once we find it stable enough given all feedbacks across all types of projects.

antoine-coulon commented 1 year ago

It seems that most use cases for Skott are running global analysis from entry points / entry directories. We can for now consider that the Skott analysis must be run from the higher level possible so that it would make this feature stable. Moreover, resolving the graph from any depth can be tricky and is not in fact really meaningful.