search

antoineco / aco-tomcat

Puppet module for Tomcat
https://forge.puppet.com/aco/tomcat
Other
9 stars 26 forks source link

Add support for complex Host setup #102

Closed HerveMARTIN closed 6 years ago

HerveMARTIN commented 6 years ago

I tried to keep the backward compatibility. I've tried it with two hosts, a context per host and no valve to see what happen when a nested component is empty.

HerveMARTIN commented 6 years ago

I've also added a param to choose the tomcat_user id, in case of multiple instance sharing the same nfs volume...

HerveMARTIN commented 6 years ago

Any update for this PR?

antoineco commented 6 years ago

Sorry, commits kept coming after I did the initial review, and then I forgot about it. Will try to look into it this week.

HerveMARTIN commented 6 years ago

Sorry for that, I had to deploy something that needed all these corrections, so I kept developping on this PR... No more commits until you review this PR, I swear :)

HerveMARTIN commented 6 years ago

@antoineco any chance you could check this PR soon?

antoineco commented 6 years ago

Again, I'm very sorry for making you wait for so long. The truth is I haven't used Puppet in 3 years now and am so busy with completely different topics now that setting up a test environment will require more work than I want to dedicate to this module.

I will merge this and release the last version of aco-tomcat based on the fact that you didn't break the API and already contributed great things to this module before. Thanks a lot for engaging with this project and for your patience :raised_hands: