Build error -Wimplicit-function-declaration with 5.9-rc4

antoineco / broadcom-wl

Broadcom Linux hybrid wireless driver (64-bit)

https://www.broadcom.com/support/download-search?pg=Wireless+Embedded+Solutions+and+RF+Components&pf=Legacy+Wireless&pa=Driver&dk=BCM4312&l=true

163 stars 47 forks source link

Build error -Wimplicit-function-declaration with 5.9-rc4 #16

Closed dilyn-corner closed 4 years ago

dilyn-corner commented 4 years ago

Just looking towards the future here with this one. If I had any level of C knowledge, I would provide a patch. Based on my knowledge, the fix should be easy though!

In src/wl/sys/wl_linux.c, segment_eq(get_fs(), KERNEL_DS) is implicitly declared. It seems this is the only such function.

antoineco commented 4 years ago

Thanks for reporting, @dilyn-corner! I haven't tried that kernel yet, but judging by the error I think you found the culprit.

I'll look into it.

antoineco commented 4 years ago

I'm not entirely sure what happened yet, but this patch (here is the actual commit) may have removed the declaration of segment_eq from asm/uaccess.h, which is included here:

https://github.com/antoineco/broadcom-wl/blob/a9362f4e4416d8e842b976fd243445711363ec24/src/wl/sys/wl_linux.c#L58

antoineco commented 4 years ago

Someone was actually faster to fix it :)

https://gist.github.com/joanbm/9e20b3842bb336379eccc12410901e37

I'm committing this right now. Thanks again 🙌