antoinefalisse / solvemuscleredundancy_dev

Development branch of the muscle redundancy solver
3 stars 0 forks source link

Select time index that corresponds with IK data #29

Closed MaartenAfschrift closed 4 years ago

MaartenAfschrift commented 4 years ago

In this PR: 1) additional example data of running 2) few lines of code to adapt the start and end time based on time vector of IK solutions. In the older version, the muscle analysis solutions can start and stop at a slightly different time than the IK and ID solution which gives problems when extracting the results of the muscle analysis solution. (The other option is to adapt the function getMuscleInfo.m if you don't like this quick fix).

Maarten

antoinefalisse commented 4 years ago

Did you close it on purpose?

MaartenAfschrift commented 4 years ago

@antoinefalisse thanks for the review. I made the changes you recommended.

antoinefalisse commented 4 years ago

Thanks @MaartenAfschrift, two more things. I think there is a typo in the model name. Should it be Running instead of GRunning? Also I would change the experimental data file names by removing the _RN21. Since there is only one trial, nicer to avoid such indexing. Thanks

MaartenAfschrift commented 4 years ago

Good idea, I renamed the files.