antoinema / tunesremote-plus

Automatically exported from code.google.com/p/tunesremote-plus
0 stars 0 forks source link

When select a song after search it plays a different song from the search results #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. using OS X 10.6.5 with latest itunes
2. searched for a song
3. selected to play result 3, plays result 1

What is the expected output? What do you see instead?
I expect to play the song i selected but it plays a different one

What version of the product are you using? On what operating system?
OS X 10.6.5 with itunes 10.1.1

Please provide any additional information below.

Original issue reported on code.google.com by finde...@gmail.com on 29 Dec 2010 at 5:25

GoogleCodeExporter commented 9 years ago
I have notified the other members of this bug who use iTunes more than myself.  
I will try and test this out and see the results myself.  I usually only test 
in MonkeyTunes but I do have iTunes installed.

Original comment by mellowaredev on 29 Dec 2010 at 9:41

GoogleCodeExporter commented 9 years ago
I just tested this against Itunes 10.1.1.4 and whatever song I pick in the 
Search Results is played properly.   So I can't duplicate this error?

Are you sure you are using TunesRemote+ 2.0.8?

Original comment by mellowaredev on 29 Dec 2010 at 10:41

GoogleCodeExporter commented 9 years ago
Yes and now I'm using 2.0.9 with same result. could the issue be my library 
size? I have 24,229 items in my music folder

Original comment by finde...@gmail.com on 30 Dec 2010 at 8:09

GoogleCodeExporter commented 9 years ago
It could be but that doesn't sound right.  24,000 songs is not many compared to 
others.  I personally have over 100,000 tracks.

Original comment by mellowaredev on 30 Dec 2010 at 10:08

GoogleCodeExporter commented 9 years ago
Hmm weird

I made a video of it happening, here you are

Original comment by finde...@gmail.com on 30 Dec 2010 at 10:32

Attachments:

GoogleCodeExporter commented 9 years ago
I definitely believe you, I just did the exact same thing here and it worked 
properly.  So now I am stumped as to why yours is different than mine!

Original comment by mellowaredev on 31 Dec 2010 at 2:38

GoogleCodeExporter commented 9 years ago
As am I :-/

Original comment by finde...@gmail.com on 31 Dec 2010 at 2:50

GoogleCodeExporter commented 9 years ago
hopefully someone else will chime in if they have the problem too or one of the 
other developers and maybe we can narrow it down.

Original comment by mellowaredev on 31 Dec 2010 at 3:06

GoogleCodeExporter commented 9 years ago
Hi, I got exactly the same problem ! You app is really great but this issue is 
very...strange ! I'm on Mac OSX 10.6 and Itunes 9.2.1 (didn't updated to 10 but 
should be the same).

Thanks !

Original comment by grosm...@gmail.com on 2 Jan 2011 at 1:20

GoogleCodeExporter commented 9 years ago
OK so the good news is at least two people now get the problem.  The bad news 
we have to figure out what you two have in common that it is not happening on 
my iTunes setup.

Original comment by mellowaredev on 2 Jan 2011 at 2:47

GoogleCodeExporter commented 9 years ago
I have exactly the same issue:

Android HTC Desire Z  Froyo 2.2 and Media Monkey 3.23 1301 on Win7x64

From the top level screen of TunesRemote 2.09 with the album art and play 
controls

1) Press the magnifying glass touch key (android) to initiate a search. A text 
entry screeen should open up with the Tunesremote Icon beside the text entry 
field and "music keywords" in dim letters inside the field
2) Manually type each letter of an artist name, such as Enya
3) A long list of tracks then come up displaying a list of every single Enya 
track I have on every album ..... exactly correct search results
4) If I click on the song "I Want Tomorrow" from the album "The Celts" it plays 
"Bodadicea" from the album "The Celts" instead.
5) If I did this for an Enya song on another album, iut would play the wrong 
song from that album
6) only one track on any album will be played the right, the rest wrong

Happens the same way every time, exactly repeatable

Happens for album searches too.........anything that results in more than one 
hit for any given album, plays the worng song on that album.

Any search that only results in 1 hit per album works perfectly

It is almost certainly a counter error ....

Please fix

Original comment by soltes.g...@gmail.com on 16 Jan 2011 at 5:33

GoogleCodeExporter commented 9 years ago
Further Analysis:

Communication Stream:
Tunesremote passes data to Apple Inc.'s Remote application which passes to 
Monkeytunes which passes to Media Monkey.

Problem:  When a search results in multiple tracks on the same album, clicking 
any track results in the wrong song being played on the right album (except for 
a single track on each album whicj will be chosen correctly.

Since searching and finding all tracks by an Artist works perfectly and if a 
given search results in only one hit on an album, the right track is 
played.....strongly suggests that the miscommunication is at the second last or 
last step of the communication flow.

When an artist search returns multiple songs on the same album, 
Tunesremote/Monkeytunes is unable to play the one clicked, but instead plays 
another on the same album, except for one track on any album which will be 
played correctly.  It is also exactly repeatable.

What is probably happening:

1) Search for Artist Enya =>  TunesRemote/Monkeytunes correctly returns 40 
songs over 4 albums and assigns each one into an array (x,y)  where x is an 
integer representing album and y an integer representing track.
2) Click on "I want tomorrow" track which is album x=2, track y=5
3)  TunesRemote/Monkeytune checks which album track represents "I want 
tomorrow" by recalling X=2 Y=5 and passes it to Media Monkey  BUT the X=2 is 
passing correctly but the Y=5 is not, instead Y=4+Z is being passed and Z is 
always the same as the same wrong track is always played.
4) One song in any album IS played correctly indicating that in this case Z=0

Original comment by soltes.g...@gmail.com on 16 Jan 2011 at 6:54

GoogleCodeExporter commented 9 years ago
Incorrect on your communication stream...

Yours: Tunesremote passes data to Apple Inc.'s Remote application which passes 
to Monkeytunes which passes to Media Monkey.

Is NOT correct.  THe real flow is this...

TunesREmote+ -> MonkeyTunes -> MediaMonkey
Apple Remote -> MonkeyTunes -> MediaMonkey

There is no intermediate call to the Apple Remote.

The bug is in TunesREmote+ the data it is sending back to the server since 
Itunes and MOnkeyTunes both have the exact same problem.  The Server is 
interpreting it correctly, the client in this case TunesREmote+ is sending an 
improper query.   The Apple Remote for the iPhone/iPad does not exhibit this 
behavior.

Original comment by mellowaredev on 16 Jan 2011 at 9:22

GoogleCodeExporter commented 9 years ago
Obviously Melloware is right about the communication stream,  I was just 
guessing about that part.

Original comment by soltes.g...@gmail.com on 16 Jan 2011 at 10:11

GoogleCodeExporter commented 9 years ago
OK, I like this program so much I figured out what the problem is.

I downloaded the sourcecode and looked it over and found the region where in 
searchactivity.java where the problem is but I don't know what is triggering 
the alphabetic sort occurs before the chosen track is sent to MonkeyTunes.

Here is what is happenning  ...... position(int) seems to be the key variable

User initiates a search for artist Clara Ponty
Tunesremote correctly loads the 11 track result into an array keyed to the 
variable "position"

User picks the first song in the list "Romance" from the Album "Clara Ponty"
Tunesremote passes "Fifer's Tale" to MonkeyTunes and that song plays instead
Looking the tracks on that Album, "Fifers Tale" is the track first in 
alphabetical order. So the first track in the list of search results is being 
converted to the first track in alphabetical order on that album.

If the second track in the search list is played then the second track in 
alphabetical order on that album will be played ....... and so on.

What is happening?

Either the list of tracks is being sorted alphabetically after the user chooses 
a track but before the chosen track reference gets portrd to Monkeytunes

OR

The position integer is not pointing to the Search Results array list a 
corresponding sorted track list in the library

Original comment by soltes.g...@gmail.com on 17 Jan 2011 at 12:55

GoogleCodeExporter commented 9 years ago
I will have to look at this closer as well.  SearchActivity.java is one of the 
classes that hasn't really been touched since the original TunesRemote came out 
in 2008 so I have never really looked at it assuming it was working.   I think 
you are on to something though that it is sending the search position back to 
the Server but not sending the query back properly for it to find the right 
position.

I did a preliminary test a month ago with a small subset of data in MonkeyTunes 
and every track I picked in the Search Results played properly in both iTunes 
and MonkeyTunes but like I said it might not have been a large enough sample 
data because clearly there is a bug here somewhere.  Just a matter of finding 
it....

Original comment by mellowaredev on 17 Jan 2011 at 2:49

GoogleCodeExporter commented 9 years ago
Looking at this further I sent you a BETA to try for monkeytunes that might fix 
the issue but it still doesn't explain why it is happening for iTunes users.  I 
think from teh MonkeyTunes side you are right the sorting is somehow 
alphabetical in one sort and non-alphabetical the next query causing it to be 
out of order.  I posted a BETA on our forums for you to test.

Original comment by mellowaredev on 17 Jan 2011 at 2:48

GoogleCodeExporter commented 9 years ago
Thanks for looking into this  .......... I will try the beta

Original comment by soltes.g...@gmail.com on 17 Jan 2011 at 4:07

GoogleCodeExporter commented 9 years ago
I also have this problem, since the original version,  so it could have been 
fixed in the beta, where can I find it?

Original comment by j.tangel...@gmail.com on 15 Feb 2011 at 7:59

GoogleCodeExporter commented 9 years ago
Are you running Monkeytunes?  If so it is available as version 1.4.9 or higher 
on the melloware.com Downloads area already.

If you are an iTunes user, the problem still persists and I think is a bug in 
TunesRemote+ we have not discovered yet.

Original comment by mellowaredev on 15 Feb 2011 at 11:53

GoogleCodeExporter commented 9 years ago
i use iTunes, recent version, 10.1.2.17.

too bad the bug isnt found yet, i love the app!

Original comment by j.tangel...@gmail.com on 16 Feb 2011 at 6:35

GoogleCodeExporter commented 9 years ago
I am having the same problem except I might be able to discern a little 
problem. For example, I have 3 Adam Sandler songs on my iTunes, Ode to My Car, 
The Talking Goat, and Food Innuendo Guy. The first 2 are under one album and 
the later is under its own. The only one "checked" is Ode to My Car. When I go 
to Adam Sandler and click on the specific album, no problem occurs with the 
song selection. It is when I go to "All" and attempt to click on the song. In 
this case, no matter which of the 3 songs that I choose, it will automatically 
play Ode to My Car.

I hope this helps.

Original comment by umdsanc...@gmail.com on 5 Mar 2011 at 11:24

GoogleCodeExporter commented 9 years ago
Adding dandroid to this list to see if he can debug this strange issue.

Original comment by mellowaredev on 25 Mar 2011 at 12:01

GoogleCodeExporter commented 9 years ago
I can reproduce this issue (iTunes on MacOSX 10.6.6). I will have a look at the 
source within the next days to find a solution.

Original comment by dandroi...@googlemail.com on 25 Mar 2011 at 12:51

GoogleCodeExporter commented 9 years ago
Excellent. I appreciate you looking into it...

Original comment by mellowaredev on 25 Mar 2011 at 1:00

GoogleCodeExporter commented 9 years ago
I just release 2.3.4 on the Android Market can you pull down the update and let 
me know if this issue is fixed?

Original comment by mellowaredev on 7 Apr 2011 at 12:19

GoogleCodeExporter commented 9 years ago
OK just published 2.3.6 please give it another shot...

Original comment by mellowaredev on 7 Apr 2011 at 3:02

GoogleCodeExporter commented 9 years ago
One user confirmed this was fixed so I am going to mark this defect fixed as of 
2.3.6

Original comment by mellowaredev on 8 Apr 2011 at 12:07