search

antoinemadec / coc-fzf

fzf :heart: coc.nvim
388 stars 28 forks source link

Saves the current location to the jumplist before jumping. #128

Closed YangchaoYi closed 1 year ago

antoinemadec commented 1 year ago

Could you please give me a small testcase that this commit fixes ?

YangchaoYi commented 1 year ago

Hi Antoine, Sure. In my case, call CocActionAsync('jumpDefinition', v:false)<CR> and jump by selecting the item doesn't save the current location and hence doesn't allow me to jump back.

I feel this pr should have positive impact.

  1. if the current location is already saved for some reason, this pr saves it again, which should be a no-op.
  2. if the current location is not saved, I believe saving it should be the desired behavior.

WDYT?