antoinepirlot / Satunes

Modern MP3 Player to listen your local music files on Android Lollipop 5.1.1+.
GNU General Public License v3.0
18 stars 2 forks source link

Compilations #606

Closed braoult closed 1 day ago

braoult commented 1 month ago

In #603, left screenshot, the 3 first lines (African Music - Benio) are part of a compilation, but shown as different albums in Satunes (maybe because of the "Artist" field, different in each song ?).

It becomes highly impractical.

My compilations are tagged with the iTunes specific TCMP frame, recognized by various players. But there is also another different common way to differentiate compilations: Using Various Artists in "Album Artist" tag. This is usually done in TPE2, which unfortunately is pretty important for classical music, but do-able.

What is the correct way to declare compilations, so they are seen correctly in Album view ?

EDIT: This is a common and usual question, not specific to Satunes: https://www.reddit.com/r/navidrome/comments/kjarq0/dealing_with_various_artists/

antoinepirlot commented 1 month ago

In #603, left screenshot, the 3 first lines (African Music - Benio) are part of a compilation, but shown as different albums in Satunes (maybe because of the "Artist" field, different in each song ?).

It becomes highly impractical.

My compilations are tagged with the iTunes specific TCMP frame, recognized by various players. But There also a different common way to differentiate compilations: Using Various Artists in "Album Artist" tag. This is usually done in TPE2, which unfortunately is pretty important for classical music, but do-able.

What is the correct way to declare compilations, so they are seen correctly in Album view ?

EDIT: This is a common and usual question, not specific to Satunes: https://www.reddit.com/r/navidrome/comments/kjarq0/dealing_with_various_artists/

Hey, yeah, at this time, if the same album has 2 different artists name it will be 2 different albums.

I'm also experiencing this problem.

I planned to check the standards about this case.

Thanks for the link

antoinepirlot commented 2 days ago

Hello @braoult ,

I modified how Satunes loads albums compilation. I would be sure I did the right choice.

Satunes now loads the music's artist and the album's artist separately.

Here's an example: Image

On the image, the album contains musics with different artist names. Satunes will add this album to "Armin Van Buuren" artist and to each musics' artist. Also, the album's musics won't be added to "Armin Van Buuren" but only in album's musics' artists.

Also, if the album is marked as compilation and the album artist is unknown, then Satunes will add the album to the "Various Artists" as album artist.

These images show you the before/after result:

You can find all modifications in this pull request: https://github.com/antoinepirlot/Satunes/pull/789

I hope this is what you ask :)

PS: don't worry, all artists won't be "Armin Van Burren" 😛

antoinepirlot commented 1 day ago

I added a new setting to let the user choose to add or not the compilation's musics to the compilation's artist's music list as for me both make sense