Syfoh Git Submodule

[MMMZZZZ]

Is your feature request related to a problem? Please describe. As far as I can see you manually copied Syfoh to this repository. Which means you'd have to check for updates and maintain that dependency.

Describe the solution you'd like A more proper solution could be to include the Syfoh repository as git submodule. Though I'll admit, I've never worked with that feature.

Describe alternatives you've considered An even cleaner way would likely be that I create a proper package that can be installed with pip. Not to be expected to happen soon though...

Kind regards, Max

[MadsBarnkob]

The current solution properly calls for this documentation to have a table of versions for syntherrupter, syfoh and tesla player that are compatible?

[MMMZZZZ]

@MadsBarnkob The Syntherrupter Sysex protocol and its implementation on the Syntherrupter side have been made with quite some thoughts about compatibility (issues). So that side shouldn‘t cause problems. Syfoh on the other hand really never made it out of the quick n dirty state under the hood. Tbh. I never considered that other people would create their own tools using Syfoh (which was a pretty big oversight on my side; it‘s quite a logic step after all).

Besides documentation, I can think of a number of improvements for Syfoh that would make it much more suitable as foundation for tools like this one (f.ex. better data structures for the commands, include min. required Syntherrupter firmwares and/or option to query support of a given command, …) - however I can‘t see when I‘d be able to implement all that.

Finally, Syfoh does have some form of versioning. Every time I make Sysex changes that affect both Syfoh and Syntherrupter (f.ex. introducing a new command) I create a tag in the Syfoh repository, marking the Syntherrupter version it‘s been released for/with. But of course this is closer to the bare minimum than to a practical, workable solution.

Kind regards, Max