search

antoineschmitt / dywapitchtrack

Dynamic Pitch Tracking Library
66 stars 11 forks source link

High end pitch detection. #6

Open pacomacman opened 3 weeks ago

pacomacman commented 3 weeks ago

You mentioned that this algorithm was tested with the human voice, but in my tests I can't detect any frequency above 1.4KHz (F6 at 1024 samples) for some reason. I am aware of singers having much bigger vocal range than this.

I noticed a hardwired maxF = 3000 which I assume to be the theoretical upper limit, but in my tests I'm getting nowhere near.

Regards Paul

antoineschmitt commented 3 weeks ago

Hello,

strange.

Indeed the original algorithm, from which the C code was directly inspired, only tested up to 1440Hz. But it is supposed to work up to 3000Hz.

https://courses.physics.illinois.edu/phys406/sp2017/NSF_REU_Reports/2005_reu/Real-Time_Time-Domain_Pitch_Tracking_Using_Wavelets.pdf

You can try to increase this maxF = 3000 value. I have never tried.

Let me know !

Le 11 juin 2024 à 14:59, pacomacman @.***> a écrit :

You mentioned that this algorithm was tested with the human voice, but in my tests I can't detect any frequency above 1.4KHz (F6 at 1024 samples) for some reason. I am aware of singers having much bigger vocal range than this.

I noticed a hardwired maxF = 3000 which I assume to be the theoretical upper limit, but in my tests I'm getting nowhere near.

Regards Paul

— Reply to this email directly, view it on GitHub https://github.com/antoineschmitt/dywapitchtrack/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPJL57UNLRRDM2FMVTNQD3ZG3YBVAVCNFSM6AAAAABJEJIYWSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DMMZXGE4TKOA. You are receiving this because you are subscribed to this thread.

Galfodo commented 3 weeks ago

Hi,

I have not really looked at the code, but I noticed that 1440 Hz is pretty close to the Nyquist frequency (1500Hz) for a sampling rate of 3000 samples/second, so perhaps you just have to multiply by 2 the maximum frequency you want to detect.

antoineschmitt commented 3 weeks ago

I thought that was the case. But maybe not. Worth a try...

Le 12 juin 2024 20:30:25 GMT+02:00, Stein Pedersen @.***> a écrit :

Hi,

I have not really looked at the code, but I noticed that 1440 Hz is pretty close to the Nyquist frequency (1500Hz) for a sampling rate of 3000 samples/second, so perhaps you just have to multiply by 2 the maximum frequency you want to detect.

-- Reply to this email directly or view it on GitHub: https://github.com/antoineschmitt/dywapitchtrack/issues/6#issuecomment-2163665158 You are receiving this because you commented.

Message ID: @.***>