anton-rs / kona

A suite of `no_std` components for the OP Stack state transition function and L2 chain derivation.
https://anton-rs.github.io/kona
MIT License
132 stars 41 forks source link

fix(primitives): op-alloy Frame Type #492

Closed refcell closed 2 months ago

refcell commented 2 months ago

Description

Removes the frame module from kona-primitives in favor of using the one from upstream op-alloy-protocol.

Will put up an issue to remove the patch.crates-io once the op-alloy-protocol pr lands and the version is bumped.

Closes #487

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.1%. Comparing base (b1ebc3c) to head (71c8141). Report is 2 commits behind head on main.

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

clabby commented 2 months ago

Looks like there's other types (Channel, BlockInfo, etc.) that we can migrate as well - can we do that now? https://github.com/alloy-rs/op-alloy/tree/main/crates/protocol/src

refcell commented 2 months ago

Looks like there's other types (Channel, BlockInfo, etc.) that we can migrate as well - can we do that now? alloy-rs/op-alloy@main/crates/protocol/src

Working on this in follow-on prs atm. They're more complicated.

Generally, it is ok to have incremental prs