anton-rs / kona

A suite of `no_std` components for the OP Stack state transition function and L2 chain derivation.
https://anton-rs.github.io/kona
MIT License
135 stars 45 forks source link

chore: Replace Custom error impls with thiserror #806

Closed refcell closed 3 days ago

refcell commented 5 days ago

Description

Since thiserror v2 was released, kona can now use the no_std compatible thiserror for use in defining custom error types instead of manually implementing the core::error::Error trait for error types with derive_more::Display. From<some_type> for CustomError should also be replaced with the #[from] syntax sugar provided by thiserror.

Perelyn-sama commented 3 days ago

I can do this

clabby commented 3 days ago

I can do this

Thanks for the interest! I went ahead and got this done as we have an upcoming release for Sepolia testnet, and would like this change included. Glad to get you involved on other work if you'd like!