Closed clabby closed 1 day ago
Pulls submitted in this stack:
main
This comment was automatically generated by st
.
Attention: Patch coverage is 90.27778%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 91.8%. Comparing base (
515366c
) to head (2a28018
). Report is 2 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Files with missing lines | Patch % | Lines |
---|---|---|
crates/proof-sdk/preimage/src/native_channel.rs | 79.4% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Overview
Introduces a
Channel
abstraction intokona-preimage
that decouples it fromkona-common
's IO abstractions. This allows forkona-preimage
consumers to not have to integrate withkona-common
, for example for the sake of witness generation runs inkona-host
.This also will allow for
kona-host
to runkona-client
natively, using in-memory channels for communication rather than an operating system pipe across processes.Temporarily, the
PipeHandle
has been relocated intokona-client
. All fault-proof-VM platform specific code will soon be isolated into its own crate.closes #398 , but needs follow-ups to remove the
kona-client
library's dependency onkona-common
as well.