anton-rs / kona

A suite of `no_std` components for the OP Stack state transition function and L2 chain derivation.
https://anton-rs.github.io/kona
MIT License
135 stars 45 forks source link

feat(preimage): Decouple from `kona-common` #817

Closed clabby closed 1 day ago

clabby commented 2 days ago

Overview

Introduces a Channel abstraction into kona-preimage that decouples it from kona-common's IO abstractions. This allows for kona-preimage consumers to not have to integrate with kona-common, for example for the sake of witness generation runs in kona-host.

This also will allow for kona-host to run kona-client natively, using in-memory channels for communication rather than an operating system pipe across processes.

Temporarily, the PipeHandle has been relocated into kona-client. All fault-proof-VM platform specific code will soon be isolated into its own crate.

closes #398 , but needs follow-ups to remove the kona-client library's dependency on kona-common as well.

clabby commented 2 days ago

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.8%. Comparing base (515366c) to head (2a28018). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/proof-sdk/preimage/src/native_channel.rs 79.4% 7 Missing :warning:
Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.