Open clabby opened 1 day ago
Pulls submitted in this stack:
main
This comment was automatically generated by st
.
Attention: Patch coverage is 21.05263%
with 30 lines
in your changes missing coverage. Please review.
Project coverage is 91.1%. Comparing base (
4a3b928
) to head (a1f66f4
).
:white_check_mark: All tests successful. No failed tests found.
Files with missing lines | Patch % | Lines |
---|---|---|
crates/proof-sdk/std-fpvm/src/io.rs | 0.0% | 22 Missing :warning: |
crates/proof-sdk/std-fpvm/src/channel.rs | 20.0% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Overview
Isolates the FPVM-specific platform code into separate crates. This solves the issues that zkVM teams are having with the
kona-client
libs being coupled to thekona-common
IO pattern.This PR will be followed up with a new
kona-client
library, that just serves the entrypoint, generic over the communicationChannel
. From there, we can runkona-client
in the host w/tokio
channels in the same process, and reuse the same logic for the entry point with akona-std-fpvm::FileChannel