antonbabenko / terraform-best-practices

Terraform Best Practices free ebook translated into ๐Ÿ‡ฌ๐Ÿ‡ง๐Ÿ‡ฆ๐Ÿ‡ช๐Ÿ‡ง๐Ÿ‡ฆ๐Ÿ‡ง๐Ÿ‡ท๐Ÿ‡ซ๐Ÿ‡ท๐Ÿ‡ฌ๐Ÿ‡ช๐Ÿ‡ฉ๐Ÿ‡ช๐Ÿ‡ฌ๐Ÿ‡ท๐Ÿ‡ฎ๐Ÿ‡ฑ๐Ÿ‡ฎ๐Ÿ‡ณ๐Ÿ‡ฎ๐Ÿ‡ฉ๐Ÿ‡ฎ๐Ÿ‡น๐Ÿ‡ฏ๐Ÿ‡ต๐Ÿ‡ฐ๐Ÿ‡ท๐Ÿ‡ต๐Ÿ‡ฑ๐Ÿ‡ท๐Ÿ‡ด๐Ÿ‡จ๐Ÿ‡ณ๐Ÿ‡ช๐Ÿ‡ธ๐Ÿ‡น๐Ÿ‡ท๐Ÿ‡บ๐Ÿ‡ฆ๐Ÿ‡ต๐Ÿ‡ฐ
https://www.terraform-best-practices.com/
Other
2.07k stars 431 forks source link

Adding Japanese Translation Pages #62

Closed shogo452 closed 2 weeks ago

shogo452 commented 1 month ago

Is your feature request related to a problem? Please describe.

ๆ—ฅๆœฌ่ชž(Japanese) appears in the language selection dropdown menu, but there are no Japanese pages.

Describe the solution you'd like

May I contribute my Japanese translations of the pages?

antonbabenko commented 1 month ago

Thanks for asking. Takashi has been working on it since yesterday. I will ask him if he needs help.

shogo452 commented 1 month ago

@antonbabenko Thank you for your response and asking to Takashi-san. Please let me know if there's anything I can do to help.

antonbabenko commented 1 month ago

I or Takashi-san will let you know if there is a need. Thanks again for reaching out!

t-okamoto1122 commented 1 month ago

@shogo452 Of course, I'd be happy to have your help! ใ‚ใ‚ŠใŒใจใ†ใ”ใ–ใ„ใพใ™๏ผ๏ผ

I thought it might be good to roughly decide on who will handle just the first few pages. After that, I think it would be good to decide responsibilities based on each otherโ€™s pace. These are the list of pages. If you have a page you would like to be in charge of, please let me know.

shogo452 commented 1 month ago

@t-okamoto1122 Thank you for your comment. And thank you also for sharing the page list. ใ‚ˆใ‚ใ—ใใŠ้ก˜ใ„ใ—ใพใ™๏ผ I would like to be in charge of Code structure and Naming conventions.

Have you created a working branch from the ja branch?

shogo452 commented 1 month ago

@antonbabenko I send you an email, please confirm it.

t-okamoto1122 commented 1 month ago

@shogo452 Before we begin let's adjust out Japanese doccument taste. I have listed the areas where individual differences may appear when translating into Japanese.

ๆ—ฅๆœฌ่ชž็ฟป่จณใ™ใ‚‹ๅ ดๅˆใ€ใ€Œไบบใซใ‚ˆใฃใฆ่ฟทใ„ใŒ็™บ็”Ÿใ—ใใ†ใ ใชใ€ๅ…ˆใซๆ–น้‡ใ‚’ๆƒใˆใฆใŠใ„ใŸใปใ†ใŒใ‚ˆใ•ใใ†ใ ใชใ€ใจๅ€‹ไบบ็š„ใซๆ€ใ†็ฎ‡ๆ‰€ใ‚’ๆŒ™ใ’ใฆใŠใใพใ™ (ใ‚ใใพใง็งใฎๅ€‹ไบบๆ„่ฆ‹ใชใฎใงๅˆฅใฎๆกˆใŒใ‚ใ‚ŒใฐใŠ็Ÿฅใ‚‰ใ›ใใ ใ•ใ„ใญ๏ผ)

shogo452 commented 1 month ago

@t-okamoto1122 Thank you for your suggestion. ๆๆกˆใ‚ใ‚ŠใŒใจใ†ใ”ใ–ใ„ใพใ™๏ผไธŠ่จ˜ใซๅˆใ‚ใ›ใพใ™๏ผ

t-okamoto1122 commented 1 month ago

@shogo452 Next, I'll take on the following pages

shogo452 commented 1 month ago

@t-okamoto1122 Next, I'll take on the following pages

Page List

t-okamoto1122 commented 1 month ago

@shogo452 I'll do Writing Terraform configurations & Workshop

shogo452 commented 1 month ago

@t-okamoto1122 I have merged the pages I was in charge of.

t-okamoto1122 commented 4 weeks ago

@shogo452 Thank you. I have also completed my pages. Let's end with a brief review of each other's pages.

t-okamoto1122 commented 4 weeks ago

@shogo452 I would like to discuss the term โ€œinfrastructure moduleโ€.

I'd like to unify all โ€œinfrastructureโ€ with โ€œใ‚คใƒณใƒ•ใƒฉโ€ to avoid making the text longer. By the way, I checked O'REILLY's book โ€œ่ฉณ่งฃ Terraformโ€, and all โ€œinfrastructure moduleโ€ is translated as โ€œใ‚คใƒณใƒ•ใƒฉใƒขใ‚ธใƒฅใƒผใƒซโ€.

Other areas seemed fine.

shogo452 commented 4 weeks ago

@t-okamoto1122 Thank you for your feedback. I fixed them to "ใ‚คใƒณใƒ•ใƒฉ" .

I would like to request modifications to the following sections.

I think the other sections are fine.

t-okamoto1122 commented 4 weeks ago

@shogo452 thank you for your review and I've fixed them.

@antonbabenko We all done!

antonbabenko commented 2 weeks ago

Thank you guys for the work! I will mention it today in the Terraform Weekly newsletter and on LinkedIn.

shogo452 commented 2 weeks ago

@antonbabenko Thank you for sharing in the Terraform Weekly newsletter. I would appreciate it if you could add the national flag to the About section of the repository.

About

Terraform Best Practices free ebook translated into ๐Ÿ‡ฌ๐Ÿ‡ง๐Ÿ‡ฆ๐Ÿ‡ช๐Ÿ‡ง๐Ÿ‡ฆ๐Ÿ‡ง๐Ÿ‡ท๐Ÿ‡ซ๐Ÿ‡ท๐Ÿ‡ฌ๐Ÿ‡ช๐Ÿ‡ฉ๐Ÿ‡ช๐Ÿ‡ฌ๐Ÿ‡ท๐Ÿ‡ฎ๐Ÿ‡ฑ๐Ÿ‡ฎ๐Ÿ‡ณ๐Ÿ‡ฎ๐Ÿ‡ฉ๐Ÿ‡ฎ๐Ÿ‡น๐Ÿ‡ฐ๐Ÿ‡ท๐Ÿ‡ต๐Ÿ‡ฑ๐Ÿ‡ท๐Ÿ‡ด๐Ÿ‡จ๐Ÿ‡ณ๐Ÿ‡ช๐Ÿ‡ธ๐Ÿ‡น๐Ÿ‡ท๐Ÿ‡บ๐Ÿ‡ฆ๐Ÿ‡ต๐Ÿ‡ฐ

antonbabenko commented 1 week ago

Great catch! I have just updated the flags with Japan being in the middle :)