search

antonbarty / cheetah-2017

Snapshot of Cheetah repository from 2017 (no longer updated)
http://www.desy.de/~barty/cheetah/Cheetah/Welcome.html
8 stars 8 forks source link

Memory bug in: cheetah_ana_pkg, crashes when events are damaged #9

Open sellberg opened 10 years ago

sellberg commented 10 years ago

FYI, there is a bug in cheetah_ana_pkg so that memory allocation for the eventData is not free'd properly if the event is damaged. I've fixed it in my branch, see:

https://github.com/antonbarty/cheetah/commit/a92f7c5a9171b387cf0695d3f526bedab86e4083

This helped runs from crashing that had many damaged events.

I also removed an excessive double loop of the 2x2 CSPAD that I do believe is not necessary. Please double-check this if you're using the 2x2 CSPAD.

I'll do a pull request to the developer branch once I'm done with my implementations. I've added a solid angle correction and polarization correction to the data last summer and have been implementing a new hitfinder algorithm that takes a list of events as input for hitfinding, which is useful to refine the data treatment at later stages.

antonbarty commented 10 years ago

Hi Jonas

Nice work - this may help fix some things such as hangs. Thanks

A..

Anton Barty Centre for Free Electron Laser Science DESY, Notkestrasse 85, 22607 Hamburg, Germany phone: +49 (0)40 8998 5783 PhD positions available: http://desy.cfel.de/cid/education/doctoralstudies/

On 28 Feb 2014, at 1:04 pm, Jonas Sellberg notifications@github.com wrote:

FYI, there is a bug in cheetah_ana_pkg so that memory allocation for the eventData is not free'd properly if the event is damaged. I've fixed it in my branch, see:

a92f7c5

This helped runs from crashing that had many damaged events.

I also removed an excessive double loop of the 2x2 CSPAD that I do believe is not necessary. Please double-check this if you're using the 2x2 CSPAD.

I'll do a pull request to the developer branch once I'm done with my implementations. I've added a solid angle correction and polarization correction to the data last summer and have been implementing a new hitfinder algorithm that takes a list of events as input for hitfinding, which is useful to refine the data treatment at later stages.

— Reply to this email directly or view it on GitHub.

chuckie82 commented 10 years ago

Hi, This could explain some lost threads during a long run. Although I've not had any datasets print warning messages to screen. Chuck

On Fri, Feb 28, 2014 at 1:32 PM, Anton Barty notifications@github.comwrote:

Hi Jonas

Nice work - this may help fix some things such as hangs. Thanks

A..

Anton Barty Centre for Free Electron Laser Science DESY, Notkestrasse 85, 22607 Hamburg, Germany phone: +49 (0)40 8998 5783 PhD positions available: http://desy.cfel.de/cid/education/doctoralstudies/

On 28 Feb 2014, at 1:04 pm, Jonas Sellberg notifications@github.com wrote:

FYI, there is a bug in cheetah_ana_pkg so that memory allocation for the eventData is not free'd properly if the event is damaged. I've fixed it in my branch, see:

a92f7c5

This helped runs from crashing that had many damaged events.

I also removed an excessive double loop of the 2x2 CSPAD that I do believe is not necessary. Please double-check this if you're using the 2x2 CSPAD.

I'll do a pull request to the developer branch once I'm done with my implementations. I've added a solid angle correction and polarization correction to the data last summer and have been implementing a new hitfinder algorithm that takes a list of events as input for hitfinding, which is useful to refine the data treatment at later stages.

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/antonbarty/cheetah/issues/9#issuecomment-36345948 .