antoncoding / monarch

easy access for morpho blue
https://monarchlend.xyz
GNU General Public License v3.0
1 stars 1 forks source link

fix: info layout, opt for mobile! #64

Closed antoncoding closed 2 days ago

antoncoding commented 2 days ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 days ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request includes multiple changes across several components. The `HomePage.tsx` has undergone layout and styling modifications, removing the background image and enhancing responsiveness. The `InfoPage` component has shifted to horizontal navigation with updated event handling. A new `Card` component has been introduced in `sectionData.tsx`, replacing existing content for better clarity. The `OracleFeedInfo` and `OracleVendorBadge` components have been refactored for improved readability without altering functionality. Lastly, `NavbarMobile.tsx` has been streamlined for better styling consistency. ## Changes | File | Change Summary | |-------------------------------------------|---------------------------------------------------------------------------------------------------------| | app/home/HomePage.tsx | Removed background image, adjusted layout and styling, centered heading, and improved button responsiveness. | | app/info/components/info.tsx | Added horizontal navigation with updated event handling, new section layout, and navigation buttons. | | app/info/components/sectionData.tsx | Introduced `Card` component for structured content display, replaced paragraphs with cards for clarity. | | src/components/FeedInfo/OracleFeedInfo.tsx | Restructured JSX for `OracleFeedInfo` for cleaner code, no functional changes. | | src/components/OracleVendorBadge.tsx | Improved readability of `renderVendorIcon` and consolidated JSX structure in `OracleVendorBadge`. | | src/components/layout/header/NavbarMobile.tsx | Streamlined mobile navigation structure and styling with a new `navbarClass` variable. | | src/utils/oracle.ts | Reformatted `parseOracleVendors` function for improved readability, logic remains unchanged. | ## Possibly related PRs - **#59**: Changes in `HomePage.tsx` are related to layout and functionality updates in the same file. - **#63**: Introduces the `OracleVendorBadge` component, relevant to the layout and responsiveness of the `HomePage`. > 🎉 In the land of code, changes unfold, > A homepage bright, with stories told. > Buttons that dance, and cards that shine, > Navigation flows, all by design. > With each little tweak, the layout sings, > A joyful update, oh, what joy it brings! 🎶

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monarch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 8:51am
antoncoding commented 1 day ago

There should be a way for selected assets to be remembered. For example, after I choose collateral=USDC, I should be able to navigate back and forth between pages while still having it remembered. This could possibly be achieved by utilizing URL parameters.

This comment was enhanced by GitButler ❤️