search

antongolub / yarn-audit-fix

The missing `yarn audit fix`
MIT License
181 stars 9 forks source link

Fix break on Windows caused by Node security fix. #335

Closed cliffAtOsaic closed 3 months ago

cliffAtOsaic commented 3 months ago

Fix for https://github.com/antongolub/yarn-audit-fix/issues/334.

The new code requires { shell: true } to be passed to child_process.sync() and child_process.spawnSync() in order to execute batch scripts. On Windows, npm and similar commands are run as "npm.cmd" rather than "npm.exe" and requires shell to be set to true.

Also fixed a warning that TypeDocs was running against an incompatible version of TypeScript. Fix was to upgrade TypeDocs to the latest version.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

antongolub commented 3 months ago

Hey, @cliffAtOsaic,

Should this option be applied for windows only?

antongolub commented 3 months ago

@cliffAtOsaic,

Thanks for highlighting the issue and for the patch. Released as part of v10.0.8. Could you verify it?

cliffAtOsaic commented 3 months ago

Upgraded to the latest and it is working now on my box. Thanks!