search

antoniandre / wave-ui

A UI framework for Vue.js 3 (and 2) with only the bright side. ☀️
https://antoniandre.github.io/wave-ui
MIT License
544 stars 39 forks source link

[w-input] Add icon slots #132

Closed DerrikMilligan closed 8 months ago

DerrikMilligan commented 10 months ago

This PR adds slots for the left and right icons on the w-input.

The use case for this is that if you want to use icons that are not in a font file with CSS classes and want to use SVG's with tree shaking that we can't put them in the input nicely.

These slots shouldn't affect any existing functionality, just enhance it by giving more options.

I also updated the documentation to explain the two new slots.

antoniandre commented 9 months ago

Hey @DerrikMilligan Thanks for the PR! Sorry I haven't been visually active lately. That's because I'm working on the autocomplete feature that I want to get done before I move on to other things. 💪 This is rather a complex task, but I'm progressing. I'll keep you posted! And btw, I appreciate your contributions so much, don't despair if I'm not reacting right away. :)

antoniandre commented 8 months ago

Hi @DerrikMilligan, I've merged that in, but when you can please also provide the icons slots in the same fashion to w-textarea and w-select so it stays consistent! Thank you! :) I'll also add it to the new autocomplete when I get there. :)

Released in version 3.8.0