search

antoniandre / wave-ui

A UI framework for Vue.js 3 (and 2) with only the bright side. ☀️
https://antoniandre.github.io/wave-ui
MIT License
553 stars 41 forks source link

[w-overlay] Prevent Body Scrolling #155

Closed DerrikMilligan closed 6 months ago

DerrikMilligan commented 6 months ago

Currently if we trigger an overlay or dialog the body behind it still scrolls. This can cause issues for various types of situations.

It's something Bootstrap back in the day implemented, removed, and then added back: https://github.com/twbs/bootstrap/pull/6342 under Modals at the end. Prevent <body> scrollbar and shifting content with overflow: hidden;.

Potentially this could also be put behind a prop if it's not behavior that everyone wants.

There's more people discussing how you could potentially implement this here

DerrikMilligan commented 6 months ago

This should actually be on the w-dialog.