search

antoniandre / wave-ui

A UI framework for Vue.js 3 (and 2) with only the bright side. ☀️
https://antoniandre.github.io/wave-ui
MIT License
553 stars 41 forks source link

[w-switch] Better Centering #158

Closed DerrikMilligan closed 4 months ago

DerrikMilligan commented 4 months ago

I had noticed that for me when viewing the w-thumb that it never quite looked centered. I was just playing around with the CSS a bit and noticed that removing this top: 0 seems to make it better centered for me on linux with both Chrome and Firefox.

Firefox Before: image

Firefox After: image

I usually have my browser zoomed in at a 125% rate so maybe that's why it's off looking sometimes. But I tried zooming in and out with the top: 0 removed and I think it looks more centered for me overall. Curious how it looks for you @antoniandre

antoniandre commented 4 months ago

Hi @DerrikMilligan, that's interesting, I just double checked on Chrome, Firefox and Safari, toggling this top 0 on and off in the 3 browsers and nothing would change at all, everything looks perfectly centered regardless. I'm on a Mac, are you on Windows? Since there is strictly no change on the 3 browsers I've checked I can merge this with not much worries, but it would be nice to know why it's not rendering the same everywhere.

Btw, have you seen my comments on the colors PR? :)

antoniandre commented 4 months ago

Mmm, I just saw u said Linux lol

antoniandre commented 4 months ago

Released in 3.13.6

DerrikMilligan commented 4 months ago

Yeah i've seen the comments. I'll get to them soon!