Closed antonieto closed 1 year ago
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Just adds a TopLayout component that we can adjust to our needs.
What is the current behavior? (You can also link to an open issue here)
No Layout. NavBar is manually placed on every page.
What is the new behavior (if this is a feature change)?
A <TopLayout>{children}</TopLayout> component that we can add to the pages where we need it.
<TopLayout>{children}</TopLayout>
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
This is how Layout works:
const SignUpPage: NextPageWithLayout = SignUp; SignUpPage.getLayout = (page) => ( <TopLayout> {page} </TopLayout> ); export default SignUpPage;
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Just adds a TopLayout component that we can adjust to our needs.
What is the current behavior? (You can also link to an open issue here)
No Layout. NavBar is manually placed on every page.
What is the new behavior (if this is a feature change)?
A
<TopLayout>{children}</TopLayout>
component that we can add to the pages where we need it.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
This is how Layout works: