search

antoninbiret / RxEureka

This library is a small RxSwift wrapper around Eureka
MIT License
37 stars 9 forks source link

Made isHighlighted reactive #13

Closed marbetschar closed 6 years ago

marbetschar commented 6 years ago

This addresses https://github.com/antoninbiret/RxEureka/issues/10

antoninbiret commented 6 years ago

Hi @marbetschar. Thanks for this PR. I'm waiting your feedback on #11 before merging this one as it uses the same tricks to avoid the memory leak.

antoninbiret commented 6 years ago

@marbetschar Could you add a test case for this new property ? After that this will be good to merge.

marbetschar commented 6 years ago

@antoninbiret test case added for isHighlighted.

antoninbiret commented 6 years ago

Thanks @marbetschar. Merged 👍