antoninbiret / RxEureka

This library is a small RxSwift wrapper around Eureka
MIT License
37 stars 9 forks source link

Good job ,but there are some compile errors #4

Closed carlosbdw closed 6 years ago

carlosbdw commented 6 years ago

Even though I pod install & set Eureka to use swift 4.0

/GitHub/RxEureka/Example/Pods/Eureka/Source/Core/Section.swift:206:1: 'Collection' requires the types 'Section.SubSequence' (aka 'Array') and 'ArraySlice' be equivalent

/GitHub/RxEureka/Example/Pods/Eureka/Source/Core/Section.swift:232:1: Type 'Section' does not conform to protocol 'RangeReplaceableCollection'

/GitHub/RxEureka/Example/Pods/Eureka/Source/Core/Section.swift:206:1: Type 'Section' does not conform to protocol 'BidirectionalCollection'

I shall be very grateful if you could tell me how to compile successfully ,thank you.

antoninbiret commented 6 years ago

Hi @carlosbdw. The library is currently not compatible with swift 4.0. I'm working on the migration on a feature branch (#5)

antoninbiret commented 6 years ago

I merged the swift 4.0 migration. Should be fine now. Feel free to reopen the issue if you still encounter build issues.