search

antoninbiret / RxEureka

This library is a small RxSwift wrapper around Eureka
MIT License
37 stars 9 forks source link

Carthage support #9

Closed marbetschar closed 6 years ago

marbetschar commented 6 years ago

Are there any plans in adding Carthage support for this library?

antoninbiret commented 6 years ago

I'm personally not a Carthage user so I didn't take time to do it (for now). PR is still welcome 🙂

marbetschar commented 6 years ago

I'll happily provide Carthage support as soon as the pull requests are merged. No pressure here. I simply need those features in my current project so I can wait for the Carthage support till the features are merged into RxEureka ;)

antoninbiret commented 6 years ago

It will be a pleasure to merge them as soon as I have your feedback on #11 😛

marbetschar commented 6 years ago

@antoninbiret what’s missing? :)

antoninbiret commented 6 years ago

Just wrote a review and forget to post it 😓. Should be visible now.