BUG: kws.Conn.Headers("user-id") or kws.Params("user-id") not working

[talksik]

Describe the bug We get empty string for headers and also params for the user id:

    app.Get("/ws", ikisocket.New(func(kws *ikisocket.Websocket) {

        // Retrieve the user id from endpoint
        userId := kws.Params("user-id")
        logrus.Infof("user id: %s", userId)

        // Add the connection to the list of the connected clients
        // The UUID is generated randomly and is the key that allow
        // ikisocket to manage Emit/EmitTo/Broadcast
        clients[userId] = kws.UUID

        // Every websocket connection has an optional session key => value storage
        kws.SetAttribute("user_id", userId)

        //Broadcast to all the connected users the newcomer
        kws.Broadcast([]byte(fmt.Sprintf("New user connected: %s and UUID: %s", userId, kws.UUID)), true)
        //Write welcome message
        kws.Emit([]byte(fmt.Sprintf("Hello user: %s with UUID: %s", userId, kws.UUID)))
    }))

Expected behavior Should properly grab the user-id from params and headers.

Screenshots

[antoniodipinto]

Hi @talksik From Fiber documentation, when you use .Params("name"), you're referring to a route parameter not to a GET Query Parameter

Here you can find an example https://github.com/antoniodipinto/ikisocket/blob/master/examples/chat_room_example/main.go#L129

As you can see the userId := kws.Params("id") takes the data from the endpoint app.Get("/ws/:id")

Please refer to this example if you want to pass data as parameter https://github.com/antoniodipinto/ikisocket/blob/master/examples/chat_room_example/main.go

For the kws.Conn.Header not grabbing data, please remember that This will allow direct access to the following FastHTTP functions that is a layer deeper than Fiber. If you want to pass data from header, you should pass it from a .Use Middleware using Locals, in your case something like:

// Setup the middleware to retrieve the data sent in first GET request
    app.Use(func(c *fiber.Ctx) error {
        // IsWebSocketUpgrade returns true if the client
        // requested upgrade to the WebSocket protocol.
        if websocket.IsWebSocketUpgrade(c) {
            c.Locals("allowed", true)
                        // grab the user id from the header
                        userId :=  c.GetRespHeader("user-id")
                        // pass it to the websocket via Locals
                        c.Locals("user_id", userId)
            return c.Next()
        }
        return fiber.ErrUpgradeRequired
    })

And then grab it from locals

    app.Get("/ws", ikisocket.New(func(kws *ikisocket.Websocket) {

        // Retrieve the user id from endpoint
        userId := kws.Locals("user_id") // <====== HERE
        logrus.Infof("user id: %s", userId)

        // Add the connection to the list of the connected clients
        // The UUID is generated randomly and is the key that allow
        // ikisocket to manage Emit/EmitTo/Broadcast
        clients[userId] = kws.UUID

        // Every websocket connection has an optional session key => value storage
        kws.SetAttribute("user_id", userId)

        //Broadcast to all the connected users the newcomer
        kws.Broadcast([]byte(fmt.Sprintf("New user connected: %s and UUID: %s", userId, kws.UUID)), true)
        //Write welcome message
        kws.Emit([]byte(fmt.Sprintf("Hello user: %s with UUID: %s", userId, kws.UUID)))
    }))

[talksik]

@antoniodipinto thank you for the detailed response!! This is perfect! I will try this out :)