antoniogarrote / rdfstore-js

JS RDF store with SPARQL support
MIT License
564 stars 109 forks source link

Nesting FILTER expressions in FILTER EXISTS not working - fix available #121

Closed datokrat closed 8 years ago

datokrat commented 8 years ago

Hi, I noticed that some nested FILTER queries are causing an error. You can find a reproducible case in the query_engine_spec.js test file of this commit: https://github.com/disco-network/rdfstore-js/commit/7119c0e1d93223d1eaa797b1c4f90088dd426eb7

I also found a possibility how to fix it by inserting only four lines of code. To see it, please consider the changes to abstract_syntax_tree.js in the same commit. I suspect that the problem was that aqt.filter happens to be an array one should iterate through (in the original code there's also the variable "i" which was not declared).

What do you think? I'm not experienced with this project so I'd appreciate to get some advice about whether to create a pull request.