search

antoniograzioli / Autodafe

Autodafe Module Pack for VCV Rack
http://www.autodafe.net/virtual-instruments/vcv-rack-modules/autodafe-module-pack-for-vcv-rack.html
Other
31 stars 7 forks source link

LFO square is essentially a pulse #17

Open bitfetcher opened 6 years ago

bitfetcher commented 6 years ago

Firstly,let me think you for these wonderful modules!

I cloned the source and built (OS X) a fresh kit and find that the square wave output of the LFO module is really a pulse wave. This was true of a prebuilt kit I had downloaded earlier. The square goes high only momentarily. This screenshot below shows it modulating a VCO sine wave and the scope shows it just modulates briefly.

I scanned the code for something obvious, but C++ is no reallyt in my programming vocabulary...

Hope it's an easy fix, and look forward to the next release!

screen shot 2018-01-22 at 9 43 25 pm
antoniograzioli commented 6 years ago

oh yes, you are right. this LFO is basically a clone of the "original" fundamental VCO, just slowed down... I'll check what happens to the pulse wave, probably pulse width is not set correctly...