search

antoniolago / react-gauge-component

React gauge component for data visualization.
https://antoniolago.github.io/react-gauge-component/
MIT License
132 stars 19 forks source link

Namespace React has no exported member JSX #27

Closed simonapostolovski closed 9 months ago

simonapostolovski commented 10 months ago

After doing npm run build it runs concurrently npm:build:* that runs build:types which basically just runs the tsc command behind the scenes.

There seems to be a typescript error in the react-gauge-component and build:types exits with code 1 but the build continues on with no issues, however this shouldn't be overlooked and should be fixed.

The second error node_modules/react-i18next/ts4.1/index.d.ts(8,3): error TS2614: Module '"i18next"' has no exported member 'TFunctionResult'. Did you mean to use 'import TFunctionResult from "i18next"' instead? isn't related to this component though and can be ignored.

I have "react": "^16.13.1", "@types/react": "^16.14.24" and TypeScript 4.9.5

image image

antoniolago commented 10 months ago

Hello, thanks for reporting this. I was not able to reproduce your error, but the project did had a lot of ts errors regarding react 17, so I cleared cache and upgraded packages and those ts errors went away, maybe it did fixed the error you're seeing in this new 1.1.30 release, please let me know.

simonapostolovski commented 9 months ago

I still have the error, it could be that I'm still on "react": "^16.13.1" but I can't upgrade the project at the moment. Its no problem thanks for checking.

antoniolago commented 9 months ago

Yeah sure, I'll try to spare some time to check the types compatibilities in react v16, feel free to reopen the issue anytime