search

antoniolg / Bandhook-Kotlin

A showcase music app for Android entirely written using Kotlin language
Apache License 2.0
1.86k stars 398 forks source link

Handle nullable mbid #16

Closed aleks-tpom6oh closed 8 years ago

aleks-tpom6oh commented 8 years ago

Description

I, as well as @alanwgeorge, noticed that the app does not work because one of the artists in the demo set does not have 'mbid'. Since this field is used to fetch additional data about the artist I think that the best solution is to drop artists that do not have this field set.

Plus I've added some tests for ArtistMapper.

antoniolg commented 8 years ago

Thanks Alexey. Ill review this and your other PRs/issues when I'm back. I'm currently on a long trip with no access to a computer.

El jue., 30 jun. 2016 8:50, Alexey notifications@github.com escribió:

Description

I, as well as @alanwgeorge https://github.com/alanwgeorge, noticed that the app does not work because one of the artists in the demo set does not have 'mbid'. Since this field is used to fetch additional data about the artist I think that the best solution is to drop artists that do not have this field set.

Plus I've added some tests for ArtistMapper.

You can view, comment on, or merge this pull request online at:

https://github.com/antoniolg/Bandhook-Kotlin/pull/16 Commit Summary

  • Handle nullable mbid

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/antoniolg/Bandhook-Kotlin/pull/16, or mute the thread https://github.com/notifications/unsubscribe/ACE8w3RsFymxrApmUVAICoBo_HcXgJQBks5qQwSugaJpZM4JBrZl .

antoniolg commented 8 years ago

This looks great. Let me know what you think about the comment I made, and I'll merge.