search

antoniolg / MaterialEverywhere

Showcase of the new AppCompat 21, which includes new Material Theme, working in pre-21 devices.
1.29k stars 306 forks source link

Transition name mislead #13

Open mbarrben opened 9 years ago

mbarrben commented 9 years ago

It's confusing that you use EXTRA_IMAGE as an intent extra (https://github.com/antoniolg/MaterialEverywhere/blob/master/app/src/main/java/com/antonioleiva/materialeverywhere/DetailActivity.java#L74), but also as a transition name between views (https://github.com/antoniolg/MaterialEverywhere/blob/master/app/src/main/java/com/antonioleiva/materialeverywhere/DetailActivity.java#L72). More confusing is that the ImageView in DetailActivity has a transition name defined (https://github.com/antoniolg/MaterialEverywhere/blob/master/app/src/main/res/layout/activity_detail.xml#L32), but later overridden with EXTRA_IMAGE (https://github.com/antoniolg/MaterialEverywhere/blob/master/app/src/main/java/com/antonioleiva/materialeverywhere/DetailActivity.java#L41).

It would be clearer if the transition name defined in the layout is the same that is used in ActivityOptionsCompat.makeSceneTransitionAnimation call. Then there's no need to call ViewCompat.setTransitionName. Even better, that transition name can be a string resource.

chipcerio commented 9 years ago

@mbarrben I agree with you. At first when I was looking at the source, it took me awhile to understand it until I checked other sources.

sharathyadhav1 commented 9 years ago

error: Error: No resource found that matches the given name: attr 'android:windowAllowReturnTransitionOverlap'.