Small thing but critical issue. Added 'return' in if--else logic in LoginInteractorImpl.java

antoniolg / androidmvp

MVP Android Example

5.94k stars 1.58k forks source link

Small thing but critical issue. Added 'return' in if--else logic in LoginInteractorImpl.java #24

Closed ckdevrel closed 7 years ago

ckdevrel commented 7 years ago

I have added 'return' in if--else logic in LoginInteractorImpl.java. I was doing null logic check for 5 to 6 edittext and it was throwing error in the 6th edittext because without return the if logic was executing till last. So i have added 'return' to return back when the error exists in the first loop. Please find the screens shot below. Awesome repo, thanks for this wonderful project.

antoniolg commented 7 years ago

Nice catch!

ckdevrel commented 7 years ago

@antoniolg Thanks! You're welcome