search

antoniolg / androidmvp

MVP Android Example
5.94k stars 1.58k forks source link

add dependency injection #8

Closed venkatesh3007 closed 8 years ago

venkatesh3007 commented 8 years ago

implement dependency injection using dagger 2 to simplify the code.

antoniolg commented 8 years ago

Hey thanks @venkatesh3007 , but I don't think it's a good idea to mix this MVP example with Dagger. Though it's true that Dagger makes it easier, people that are not used to it will not understand the code. I prefer to have both examples (this and https://github.com/antoniolg/DaggerExample ) separate so that it's easier to digest for less experienced developers.

venkatesh3007 commented 8 years ago

no problem @antoniolg . You are right, it's better to keep the MVP example simple.