search

antoniomika / sish

HTTP(S)/WS(S)/TCP Tunnels to localhost using only SSH.
https://ssi.sh
MIT License
4.03k stars 308 forks source link

Restrict tunnel subdomains to author SSH fingerprint #313

Open grabbou opened 4 months ago

grabbou commented 4 months ago

Hey!

Thanks for making Sish, it's been working really great for our Open Source project. For context, we're using it to set up tunnel session from your local development machine, so you can distribute the URL to your friends to preview your work.

We are using stable subdomains (e.g. xxx.proxy.com) and right now, anyone knowing the xxx can set it, if correct flags are specified.

I wanted to keep things as stateless. After investigating the source code, I think the best mechanism to utilise is providing custom HTTP service to validate public keys.

Unfortunately, there's no "subdomain" in the body, just the public key, remote address and the user. If there was subdomain and port user is trying to set up tunnel, that would do it!

grabbou commented 4 months ago

This issue can be closed, but FYI, I ended up modifying source code to provide an option to automatically generate URL as a hash of subdomain and fingerprint.

antoniomika commented 3 months ago

Hey there @grabbou,

Sorry for the delay, I was traveling for the past few weeks!

The current way of limiting domain access is through DNS, so your method works best for "deterministic urls". Happy to accept contributions on adding that ability though!

Hope that helps!