search

antonioribeiro / countries

Laravel countries and currencies
BSD 3-Clause "New" or "Revised" License
1.82k stars 283 forks source link

Incompatible types between PragmaRX\Countries\Package\Services\Cache\Service and Psr\SimpleCache\CacheInterface #207

Open ghunti opened 1 week ago

ghunti commented 1 week ago

Hi @antonioribeiro

The latest version of thhis package, changed the compatiblity of the psr/simple-cache to ^3.0. The problem is that now there's an incompatibility between PragmaRX\Countries\Package\Services\Cache\Service and Psr\SimpleCache\CacheInterface:

Declaration of PragmaRX\Countries\Package\Services\Cache\Service::get($key,  $default = null) 
must be compatible with Psr\SimpleCache\CacheInterface::get(string $key, mixed $default = null): mixed
antonioribeiro commented 1 week ago

Yes, sorry about that, I believe I'll have to tag a major version on this one as it's a breaking change. Are you able to use a fixed version (previous one) for now?

ghunti commented 1 week ago

Hi @antonioribeiro No problem on my side :-) Would adding a return type of :mixed be considered a BC? Because I think it's the only thing missing