search

antonioribeiro / firewall

Firewall package for Laravel applications
BSD 3-Clause "New" or "Revised" License
1.39k stars 164 forks source link

Fix redirect functionality for redirect_non_whitelisted_config value #161

Open mrgswift opened 5 years ago

mrgswift commented 5 years ago

I have been using this firewall package for a while. Thank you!!! Today for the first time, I had a use case where I needed to assign a url to redirect_non_whitelisted_to in my firewall config. After doing so, I noticed the redirect was not working for non-whitelisted users. It returned the http response code defined in the responses.whitelist config value but was completely ignoring the redirect_non_whitelisted_to config value.

I investigated further and noticed a refactor at commit 075b69b, which appears to have removed the condition to check the value of redirect_non_whitelisted_to. I refactored the Whitelist filter function a little bit to fix this.

mrgswift commented 5 years ago

Bump. Just wondering if you have taken a look at this yet. Thanks!

bennettblack commented 3 years ago

@mrgswift Have you by chance found a similar package that is actively maintained?