search

antonioribeiro / google2fa

A One Time Password Authentication package, compatible with Google Authenticator.
MIT License
1.83k stars 199 forks source link

Fix BC for previous php versions #139

Closed KartaviK closed 3 years ago

GrahamCampbell commented 4 years ago

👎

mfn commented 4 years ago

I'm torn.

I mean the library isn't very actively developed but now suddenly carrying forward this baggage for BC reasons.. what's you justification for this?

antonioribeiro commented 4 years ago

Not willing to go down this road to support PHP 5.4+, and I should now probably agree with @GrahamCampbell on the current PHP version, right? :/

antonioribeiro commented 4 years ago

@KartaviK , I just created a new branch 7.x. Are you able to fix these conflicts?

I think most of the changes you are doing can be possibly dropped in favor of a code that supports only PHP < 7.1, including PHPUnit version. Then we would have to keep this branch in sync with 8.x.

GrahamCampbell commented 4 years ago

It is still possible to run travis on those old versions btw.

GrahamCampbell commented 4 years ago

Example: https://github.com/schmittjoh/php-option/blob/1.5.3/.travis.yml.

GrahamCampbell commented 4 years ago

https://github.com/antonioribeiro/google2fa/pull/152

antonioribeiro commented 4 years ago

@GrahamCampbell , Yeah, I just want to free the 8.x branch to move forward, but the idea is to keep them both running on Travis.

Thanks for all your contributions ❤️

antonioribeiro commented 3 years ago

Sorry, I will pass on this one.

mfn commented 3 years ago

Good call IMHO